Remove config validation warnings: "unrecognized property 'module'" #575
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Have you guys managed to resolve the issue other than updating manually: |
|
@DarrenStack can you update against master? Having that we will be able to merge this |
|
what is required to get this merged into master? |
|
@rileypriddle There are failing tests - it should be rebased on top of current master branch, additionally, it should be good to introduce a change where the schema is applied only if the functionality for adding it is exposed by the Framework so we will avoid breaking it for older versions of the Framework. Would you be interested in tackling that? |
|
Closing in favor of: #641 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also brought up here: serverless/serverless#8423
Function Schema Validation is executed by default with the update from Serverless to 2.7.0. This picks up validation errors for the "module" keyword which is used in this plugin.
In Serverless 2.10.0, they introduced the "defineFunctionProperties" function serverless/serverless#8462 This can be used to extend the aws function definition to include new keywords.
I believe adding the following code to the constructer of the plugin would eliminate these warnings but it would cause errors with anyone using a version of Serverless before 2.10.0.