Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support custom git config #833

Closed
wants to merge 3 commits into from
Closed

Conversation

shaug
Copy link

@shaug shaug commented Mar 14, 2024

This allows for, among other things, relying on git URL mappings, which can normalize protocols:

git config --global url."ssh://git@github.com".insteadOf "https://github.com"

Or add credentials from environment variables for a CI tool:

git config --global \
    url."https://${USERNAME}:${PASSWORD}@github.com/${OWNER}/".insteadOf \
    "https://github.com/${OWNER}/"

I have a project relying on this change and it is working spendidly.

This allows for, among other things, mapping URLs to provide authentication for private repos.
@pgrzesik
Copy link
Contributor

Hey @shaug - thanks a lot for the proposal, overall it makes sense 👍 There are failing checks in CI though (prettier-related it seems), could you please take a look into that?

@shaug
Copy link
Author

shaug commented Mar 19, 2024

Thanks, @pgrzesik. The code has been prettified.

@pgrzesik
Copy link
Contributor

Hey @shaug - unfortunately it seems like the tests are failing as well - if you'd be able to take a look it will be much appreciated 🙇

@shaug shaug closed this May 16, 2024
@shaug
Copy link
Author

shaug commented May 16, 2024

I'm having too many problems figuring out how to get the unit tests to work. I'll figure out a different solution.

@pgrzesik
Copy link
Contributor

Sounds good, please let me know if there's a way I could help 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants