Avoid args being rounded and converted to numbers #5361
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What did you implement:
Closes #5050
How did you implement it:
After the CLI get the args, before the pass to the 'minimist' I'm handling the string values and encode their to a base64 string like a workaround. After the minimist process, I get again the values and decoded again to get the original values.
How can we verify it:
If we test the CLI with numbers and numbers like strings always they going to be treated as strings:
Also, there is a unit test added:
If we only executed it, we'll we have:

Todos:
Is this ready for review?: YES
Is it a breaking change?: NO