Changed AWS subscription filters to use function object name #6402
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What did you implement:
Closes #5700
How did you implement it:
Just changed the expecting log subscription ARN from being calculated using
functionName
(which is always the name of the function object inserverless.yml
, to instead usefunctionObj.name
, which will use thename
field if provided, and the default name if not (as it is set in thesetFunctioNames
method inService.js
).How can we verify it:
serverless deploy
a function with CloudWatch Logs triggers and with thename
field set (an example is given in the original issue and re-listed below).Opening CloudWatch will show subscriptions for each of the log groups. Re-deploying (using
serverless deploy --force
) will cause all of the subscriptions to disappear in the upstream repo, but will not with these changes.Todos:
Note: Run
npm run test-ci
to run all validation checks on proposed changesValidate via
npm test
Validate via
npm run lint-updated
Note: Some reported issues can be automatically fixed by running
npm run lint:fix
Validate via
npm run prettier-check-updated
Note: All reported issues can be automatically fixed by running
npm run prettify-updated
Is this ready for review?: YES
Is it a breaking change?: NO