Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace use of tenant with org in docs & templates #6655

Merged
merged 1 commit into from
Sep 9, 2019
Merged

Conversation

dschep
Copy link
Contributor

@dschep dschep commented Sep 9, 2019

What did you implement:

  • replace tenant with org in docs & tmplates
  • added comment about purpose of app & org since we get so many bug reports from people randomly(afaict) uncommenting them without knowing why.

How did you implement it:

sed

How can we verify it:

read the docs or use a template via sls create from this sls branch

Todos:

Note: Run npm run test-ci to run all validation checks on proposed changes

  • Write tests and confirm existing functionality is not broken.
    Validate via npm test
  • Write documentation
  • Ensure there are no lint errors.
    Validate via npm run lint-updated
    Note: Some reported issues can be automatically fixed by running npm run lint:fix
  • Ensure introduced changes match Prettier formatting.
    Validate via npm run prettier-check-updated
    Note: All reported issues can be automatically fixed by running npm run prettify-updated
  • Make sure code coverage hasn't dropped
  • Provide verification config / commands / resources
  • Enable "Allow edits from maintainers" for this PR
  • Update the messages below

Is this ready for review?: NO
Is it a breaking change?: NO

@dschep dschep requested a review from medikoo September 9, 2019 14:57
Copy link
Contributor

@medikoo medikoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@dschep dschep merged commit f187ba7 into master Sep 9, 2019
@dschep dschep deleted the org-not-tenant branch September 9, 2019 15:43
@medikoo medikoo added this to the 1.52.0 milestone Sep 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants