-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AWS Deploy: Fix "sls deploy function" error handling #9102
Conversation
3d0100d
to
d688e4e
Compare
Codecov Report
@@ Coverage Diff @@
## master #9102 +/- ##
==========================================
+ Coverage 87.20% 87.22% +0.02%
==========================================
Files 290 290
Lines 11102 11104 +2
==========================================
+ Hits 9682 9686 +4
+ Misses 1420 1418 -2
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch 👍
Any AWS SDK rejection is reported as if it's function not yet deployed error, e.g. missing credentials issue is also reported like that.
This patch fixes that