Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AWS Deploy: Fix "sls deploy function" error handling #9102

Merged
merged 2 commits into from
Mar 11, 2021

Conversation

medikoo
Copy link
Contributor

@medikoo medikoo commented Mar 11, 2021

Any AWS SDK rejection is reported as if it's function not yet deployed error, e.g. missing credentials issue is also reported like that.

This patch fixes that

@medikoo medikoo force-pushed the 0311-fix-not-existing-function-deployment branch from 3d0100d to d688e4e Compare March 11, 2021 13:57
@codecov
Copy link

codecov bot commented Mar 11, 2021

Codecov Report

Merging #9102 (caad7f6) into master (6537a5e) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9102      +/-   ##
==========================================
+ Coverage   87.20%   87.22%   +0.02%     
==========================================
  Files         290      290              
  Lines       11102    11104       +2     
==========================================
+ Hits         9682     9686       +4     
+ Misses       1420     1418       -2     
Impacted Files Coverage Δ
lib/plugins/aws/deployFunction.js 96.62% <100.00%> (+1.17%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6537a5e...d688e4e. Read the comment docs.

@medikoo medikoo requested a review from pgrzesik March 11, 2021 14:07
Copy link
Contributor

@pgrzesik pgrzesik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch 👍

@medikoo medikoo merged commit aa7b66a into master Mar 11, 2021
@medikoo medikoo deleted the 0311-fix-not-existing-function-deployment branch March 11, 2021 15:55
This was referenced Mar 16, 2021
This was referenced Mar 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants