Skip to content

Commit

Permalink
Remove require from Workflow.Start and remove assert Workflow.Start f…
Browse files Browse the repository at this point in the history
…rom parser/parser_test.go

Signed-off-by: André R. de Miranda <andre@galgo.tech>
  • Loading branch information
ribeiromiranda committed Mar 9, 2023
1 parent 7b4c2e2 commit 57245f2
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 3 deletions.
2 changes: 1 addition & 1 deletion model/workflow.go
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@ type BaseWorkflow struct {
Description string `json:"description,omitempty"`
// Workflow version
Version string `json:"version" validate:"omitempty,min=1"`
Start *Start `json:"start,omitempty" validate:"required"`
Start *Start `json:"start,omitempty"`
// Annotations List of helpful terms describing the workflows intended purpose, subject areas, or other important qualities
Annotations []string `json:"annotations,omitempty"`
// DataInputSchema URI of the JSON Schema used to validate the workflow data input
Expand Down
2 changes: 0 additions & 2 deletions parser/parser_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -365,8 +365,6 @@ func TestFromFile(t *testing.T) {

// Workflow "name" no longer a required property
assert.Empty(t, w.Name)
// Workflow "start" no longer a required property
assert.Equal(t, w.States[0].Name, w.Start.StateName)

// Functions:
assert.NotEmpty(t, w.Functions[0])
Expand Down

0 comments on commit 57245f2

Please sign in to comment.