Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

states - unsupported AST kind *ast.InterfaceType #148

Merged
merged 2 commits into from
Mar 7, 2023
Merged

states - unsupported AST kind *ast.InterfaceType #148

merged 2 commits into from
Mar 7, 2023

Conversation

spolti
Copy link
Member

@spolti spolti commented Mar 1, 2023

Fixes #144

Many thanks for submitting your Pull Request ❤️!

What this PR does / why we need it:

Special notes for reviewers:

Additional information (if needed):

@github-actions github-actions bot added the source label Mar 1, 2023
@spolti spolti force-pushed the stateInterface branch 3 times, most recently from 2149bca to 724834a Compare March 3, 2023 21:08
ricardozanini
ricardozanini reviewed Mar 6, 2023
View reviewed changes
Copy link
Member

@ricardozanini ricardozanini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@spolti let me know when this one is finished. Maybe we can switch it to draft?

@spolti spolti marked this pull request as draft March 6, 2023 13:17
@spolti
Copy link
Member Author

spolti commented Mar 6, 2023

@spolti let me know when this one is finished. Maybe we can switch it to draft?

yes, moved to draft.
probably by tomorrow, only missing some tests by now.

@spolti spolti force-pushed the stateInterface branch 5 times, most recently from 14d92ea to c6f0d54 Compare March 6, 2023 23:43
@spolti spolti marked this pull request as ready for review March 6, 2023 23:43
@spolti
Copy link
Member Author

spolti commented Mar 6, 2023

@ricardozanini it is ready for review.
About the CI issue, it is codecov upload failure, not sure what is causing it.

ricardozanini
ricardozanini reviewed Mar 7, 2023
View reviewed changes
Copy link
Member

@ricardozanini ricardozanini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems that we have a clear way of unmarshalling now and supporting Kubernetes types at the same time. Well done! I believe we should release a new major version now since there are a few changes in the interface and implementation structure. This new version is to enhance k8s compatibility.

model/callback_state.go Show resolved Hide resolved
model/callback_state_test.go Outdated Show resolved Hide resolved
model/inject_state_test.go Outdated Show resolved Hide resolved
model/states.go Show resolved Hide resolved
@ricardozanini
Copy link
Member

@ricardozanini it is ready for review. About the CI issue, it is codecov upload failure, not sure what is causing it.

Fix it here: #149

@spolti
states - unsupported AST kind *ast.InterfaceType
ad31e9a 
Fixes serverlessworkflow#144

Signed-off-by: Spolti <filippespolti@gmail.com>
@spolti
rebase and review suggestions
ff8eacb 
Signed-off-by: Spolti <filippespolti@gmail.com>
@ricardozanini ricardozanini merged commit 923dcdf into serverlessworkflow:main Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ricardozanini ricardozanini ricardozanini approved these changes

Assignees
No one assigned
Labels
source
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

states.go:66:12: unsupported AST kind *ast.InterfaceType
2 participants
@spolti @ricardozanini