Fixed Cron.ValidUntil using incorrect ISO8601 parsing format #187
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The parsing method currently used for validating
Cron.ValidUntil
tries to convert the given value to ISO8601 Duration when it should be parsing for Datetime.You can see this in the 0.8 spec's example definition found here: https://github.com/serverlessworkflow/specification/blob/0.8.x/specification.md#cron-definition
Special notes for reviewers:
If there is a preference for a different ISO8601 timestamp parser library over github.com/relvacode/iso8601 I am welcome to any suggestions.