Skip to content

#181/bug/fix #205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
+2 −1
Closed

#181/bug/fix #205

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
92e4a48
Modified validTransitionAndEnd func to skip validation for compensati…
Aug 18, 2023
1e982b6
Merge branch 'serverlessworkflow:main' into #181/bug/fix
ilewin Sep 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion model/workflow_validator.go
View file
Original file line number Diff line number Diff line change
@@ -218,8 +218,9 @@ func transitionStructLevelValidationCtx(ctx ValidatorContext, structLevel valida
func validTransitionAndEnd(structLevel validator.StructLevel, field any, transition *Transition, end *End) {
hasTransition := transition != nil
isEnd := end != nil && (end.Terminate || end.ContinueAs != nil || len(end.ProduceEvents) > 0) // TODO: check the spec continueAs/produceEvents to see how it influences the end
usedForCompensation := field.(BaseState).UsedForCompensation

if !hasTransition && !isEnd {
if !hasTransition && !isEnd && !usedForCompensation {
structLevel.ReportError(field, "Transition", "transition", val.TagRequired, "")
} else if hasTransition && isEnd {
structLevel.ReportError(field, "Transition", "transition", val.TagExclusive, "")