-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes workflow event states unmarshalling methods #65
Fixes workflow event states unmarshalling methods #65
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi! Thanks for this change. Can you please add a unit test to validate the unmarshaling? Many thanks!
@ricardozanini should be good now, I added a small case with both states and making sure it compiles which is the small issue I'm solving, you can quickly confirm the issue changing the code back to the original way and run the test. Let me know if something else is required ^^. Thank u! |
@andresmijares let me know if you need a new patch release. |
@ricardozanini after the merge, that would be great! i've been using a fork of the project only cause this :) |
Actually, I'll upgrade the Go version and try to fix the CI. Something is not quite right. See #63 |
@andresmijares, I've fixed all these CI bugs and dependencies problems here: #66 Can you please take a look and try that PR locally to see if it's fine on your side so I can merge it? We then rebase this and do a release. |
@ricardozanini i just sourced this branch on my project and ran without problem (without considering the issues fixed in this PR)! go version go1.18.3 darwin/amd64 Just in case |
@andresmijares can you rebase now that I've merged #63? |
@ricardozanini done! thank you! |
@ricardozanini last question, not related to the PR, is there any slack channel for ppl sharing ideas about this project? |
Sure thing: https://cloud-native.slack.com/ Go to |
@ricardozanini i need an invitation, could u send me one pls? email is github user, gmail, thanks!! |
@andresmijares, many thanks for this contribution. I'm releasing a new patch version this afternoon. |
@andresmijares, the slack channel is open. I tried to add you to the channel, but it has been disabled. IDK why. You should be able to join, nevertheless. |
@ricardozanini i think it's disabled, i tried joining and it says i dont have an account and i need one :( |
You just have to create a free account, I believe. |
it seems it is set as invited only, not public joining option |
thank you! |
Worked? |
yes sir! |
Great, I'll update our docs. |
Many thanks for submitting your Pull Request ❤️!
What this PR does / why we need it:
Actually, there's a small bug preventing to have
Event Switch State
andEvent Data State
on the same definition, this creates a small case where the other of the states only works if they are placed certain way, it's not deterministic.We are using the sdk but we had to fork it in order to make it work correctly, I think, others will benefit from it.
How to reproduce it.
Given this definition:
This line it's causing that when trying to unmashalling
Sample2
,mapState
is not cleared for the next loop iteration, somap[dataConditions]
is notnil
. This cause this line to be trigger wrongly, when there are 2 switch events and aSwitch Event Database
is place before theSwitch Event
.Clearing
mapState
before the next iteration of the loop should solve the issue.Please, let me know, if anything else is needed.
Special notes for reviewers:
Additional information (if needed):