Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix #418] Adding const support #419

Merged
merged 2 commits into from
Aug 28, 2024
Merged

[Fix #418] Adding const support #419

merged 2 commits into from
Aug 28, 2024

Conversation

fjtirado
Copy link
Collaborator

@fjtirado fjtirado commented Aug 28, 2024 •
edited
Loading

Fix #418

@fjtirado
[Fix serverlessworkflow#418] Adding const support
d0f17a0 
Signed-off-by: Javier <ftirados@redhat.com>
@fjtirado
Copy link
Collaborator Author

fjtirado commented Aug 28, 2024 •
edited
Loading

Pattern annotation has been added to generated POJO.
Next step is to make jackson deserializer validate JSR 303 annotations
This makes some working workflow to fail because of missing mandatory parameters (like, for example, version)

@fjtirado
[Fix serverlessworkflow#418] Adding Jsr 303 validation support
3b65612 
Notice that this will force us to add version and other mandatory field
we were not including in the examples

Signed-off-by: Javier <ftirados@redhat.com>
@fjtirado fjtirado marked this pull request as ready for review August 28, 2024 17:39
@fjtirado fjtirado requested a review from ricardozanini August 28, 2024 17:40
@fjtirado fjtirado merged commit f8dbe54 into serverlessworkflow:main Aug 28, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ricardozanini ricardozanini ricardozanini approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support const keyword in generator
2 participants
@fjtirado @ricardozanini