fix: update wait and set task syntax #7
Merged
+217
−33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arminhammer
force-pushed
the
fix-set-and-wait
branch
from
d63ff73 to
689bebc
Compare
cdavernas
requested changes
Nov 29, 2025
Member
cdavernas
left a comment
cdavernas
left a comment
There was a problem hiding this comment.
Looks great to me! Thanks ❤️
Can I however ask you to sign-off your commits so that DCO passes?
arminhammer
force-pushed
the
fix-set-and-wait
branch
from
689bebc to
6c9eca2
Compare
fix: update wait and set task syntax Signed-off-by: Armin Graf <arminhammer@gmail.com>
arminhammer
force-pushed
the
fix-set-and-wait
branch
from
6c9eca2 to
f87d2f5
Compare
Contributor
Author
|
Sorry, forgot to sign the commit! Should be fixed now and ready to go. |
cdavernas
approved these changes
Nov 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR fixes a couple of inconsistencies between the spec and the sdk that I ran into:
The Wait Task has the property
wait(https://github.com/serverlessworkflow/specification/blob/main/dsl-reference.md#wait), but in the current code it is set toduration. This PR renames it towaitto align with the spec.The Run Task Script (https://github.com/serverlessworkflow/specification/blob/main/dsl-reference.md#script-process) a. the spec defines a
stdinproperty that is missing in the current code. This PR adds that property.b. the spec defines arguments as a list of strings, but the current code has it defined as a
HashMap. This PR updates it to aVec<String>to match the spec.The Set Task (https://github.com/serverlessworkflow/specification/blob/main/dsl-reference.md#set) defines the
setproperty as being either amapor astringtype, with the string type being an expression. The current code defines it as aHashMap, making it impossible to define it as a string expression. This PR introduces a complex typeSetValue, which can be either aHashMapor anExpression, adding support for either type.Special notes for reviewers:
I tried to add useful unit tests to test and validate the new behavior.
Additional information (if needed):