Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix-183: Dash character in names breaks the Mermaid diagram output #184

Conversation

JBBianchi
Copy link
Member

Many thanks for submitting your Pull Request ❤️!

What this PR does / why we need it:

  • Handles dashes in states' name
  • Formats the nodes labels to a "human readable" string (e.g.: my-state becomes My State)

Special notes for reviewers:

Additional information (if needed):

Closes #183

Closes serverlessworkflow#183

Signed-off-by: Jean-Baptiste Bianchi <jb.bianchi@neuroglia.io>
Copy link
Member

@antmendoza antmendoza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @JBBianchi

@ricardozanini ricardozanini merged commit af7a343 into serverlessworkflow:main Feb 29, 2024
6 checks passed
@JBBianchi JBBianchi deleted the fix-183-support-dashes-in-names branch August 9, 2024 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dash character in names breaks the Mermaid diagram output.
3 participants