Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix endpoint URI format in workflow SCHEMA #878

Closed
ricardozanini opened this issue Jun 3, 2024 · 0 comments · Fixed by #879
Closed

Fix endpoint URI format in workflow SCHEMA #878

ricardozanini opened this issue Jun 3, 2024 · 0 comments · Fixed by #879
Assignees
Labels
area: spec Changes in the Specification change: fix Something isn't working. Impacts in a minor version change. spec: 1.0.0

Comments

@ricardozanini
Copy link
Member

What seems off:
The Workflow Schema uses the uri format in the endpoint property. This format is not valid for template URI like https://petstore.swagger.io/v2/pet/{petId}

What you expected to be:
That either URI and URI template passes the schema tests. See https://json-schema.org/understanding-json-schema/reference/string#resource-identifiers

Anything else we need to know?:
See GHA failure from #865 PR.

Environment:

  • Specification version used:
    1.0.0-alpha1
@ricardozanini ricardozanini added change: fix Something isn't working. Impacts in a minor version change. area: spec Changes in the Specification spec: 1.0.0 labels Jun 3, 2024
@ricardozanini ricardozanini self-assigned this Jun 3, 2024
ricardozanini added a commit to ricardozanini/sw-specification that referenced this issue Jun 3, 2024
…dpoint attribute

Signed-off-by: Ricardo Zanini <zanini@redhat.com>
ricardozanini added a commit that referenced this issue Jun 3, 2024
Fix #878 - Fix URI format in workflow schema for endpoint attribute
matthias-pichler pushed a commit to matthias-pichler/specification that referenced this issue Jun 5, 2024
…dpoint attribute

Signed-off-by: Ricardo Zanini <zanini@redhat.com>
Signed-off-by: Matthias Pichler <m.pichler@warrify.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: spec Changes in the Specification change: fix Something isn't working. Impacts in a minor version change. spec: 1.0.0
Projects
Status: Done
1 participant