Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added new reusable components and fixed unreferenceable errors and retries #1002

Merged
merged 3 commits into from
Aug 30, 2024
Merged

Added new reusable components and fixed unreferenceable errors and retries #1002

merged 3 commits into from
Aug 30, 2024

Conversation

cdavernas
Copy link
Member

Please specify parts of this PR update:

  • Specification
  • Schema
  • Examples
  • Extensions
  • Use Cases
  • Community
  • CTK
  • Other

What this PR does:

  • Adds reusable timeouts, referenceable from WorkflowDefinitions and TaskDefinitions
  • Fixes both the DSL documentation and schema to allow referencing errors and retry policies when authoring TryTaskDefinitions and RaiseTaskDefinitions
  • Adds new examples to illustrate features and fixes

@cdavernas
- Updated both the DSL documentation and schema to allow referencing …
2eb0bac 
…reusable timeouts from the WorkflowDefinition and the TaskDefinitions it is made out of

- Updated both the DSL documentation and schema to allow referencing errors and retry policies when authoring TryTaskDefinitions and RaiseTaskDefinitions
- Added new examples to illustrate features and fixes

Signed-off-by: Charles d'Avernas <charles.davernas@neuroglia.io>
@cdavernas cdavernas added change: fix Something isn't working. Impacts in a minor version change. change: documentation Improvements or additions to documentation. It won't impact a version change. change: feature New feature or request. Impacts in a minor version change area: spec Changes in the Specification labels Aug 30, 2024
@cdavernas cdavernas added this to the v1.0.0 milestone Aug 30, 2024
@cdavernas cdavernas merged commit fbcd135 into serverlessworkflow:main Aug 30, 2024
3 checks passed
@cdavernas cdavernas deleted the fix-component-references branch August 30, 2024 14:22
cdavernas added a commit to serverlessworkflow/sdk-net that referenced this pull request Aug 30, 2024
@cdavernas
feat(Sdk): Added services to fluently validate the DSL
213e696 
fix(Sdk): Added referenceable timeouts and retries, thus addressing serverlessworkflow/specification#1002

Signed-off-by: Charles d'Avernas <charles.davernas@neuroglia.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ricardozanini ricardozanini ricardozanini approved these changes

Assignees

@ricardozanini ricardozanini

Labels
area: spec Changes in the Specification change: documentation Improvements or additions to documentation. It won't impact a version change. change: feature New feature or request. Impacts in a minor version change change: fix Something isn't working. Impacts in a minor version change.
Projects
Progress Tracker
Status: Done
Milestone
v1.0.0-alpha3
Development

Successfully merging this pull request may close these issues.
2 participants
@cdavernas @ricardozanini