Fix support for workflow extensions #539
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tihomir Surdilovic <tihomir@temporal.io>
tsurdilo
requested review from
cdavernas,
manuelstein and
ricardozanini
as code owners
ricardozanini
approved these changes
Dec 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Tihomir Surdilovic tihomir@temporal.io
Many thanks for submitting your Pull Request ❤️!
Please specify parts this PR updates:
What this PR does / why we need it:
Currently, each extension definition had to define the workflow id and versions for which it applies for. That made it impossible to reuse extension defs between multiple workflow defs.
This change adds a top-level "extensions" prop (array or path to url, string) which allows in the workflow def to say which extensions you want to apply to that workflow definition.