Fix #852 - Add cache path to node CI and remove examples hydration pipeline #861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mples hydration pipeline Signed-off-by: Ricardo Zanini <zanini@redhat.com>
Signed-off-by: Ricardo Zanini <zanini@redhat.com>
Signed-off-by: Ricardo Zanini <zanini@redhat.com>
ricardozanini
requested review from
tsurdilo,
cdavernas and
antmendoza
as code owners
cdavernas
approved these changes
May 28, 2024
|
LGTM, the only thing I notice is that |
JBBianchi
approved these changes
May 29, 2024
fjtirado
approved these changes
May 29, 2024
fjtirado
reviewed
May 29, 2024
fjtirado
approved these changes
May 29, 2024
It will as soon as we fix serverlessworkflow/serverlessworkflow.github.io#198 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many thanks for submitting your Pull Request ❤️!
Please specify parts of this PR update:
Discussion or Issue link:
Fixes #852
What this PR does / why we need it:
In this PR, we reintroduce the example check in order to validate our schema. There was a change in the code base to address YAML parsing and transformation to JSON since the underlying library only accepts JSON. 😢
@JBBianchi can you please take a look in the typescript? 🙏