Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #862 - Switch 'then' must accept free strings #863

Merged
merged 1 commit into from
May 29, 2024

Conversation

ricardozanini
Copy link
Member

Please specify parts of this PR update:

  • Specification
  • Schema
  • Examples
  • Extensions
  • Use Cases
  • Community
  • CTK
  • Other

Discussion or Issue link:

Fixes #862

What this PR does:

This is somewhat questionable since the text is, in practice, an open string. At least it's validating the attribute and documenting the enum.

Additional information:

Signed-off-by: Ricardo Zanini <zanini@redhat.com>
Copy link
Member

@cdavernas cdavernas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks man!

@cdavernas cdavernas merged commit e4cd93f into serverlessworkflow:main May 29, 2024
3 checks passed
@ricardozanini ricardozanini deleted the issue-862 branch May 31, 2024 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

flowDirective schema does not support task names
2 participants