-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix workflow schema: change const
, adding missing object
; etc.
#876
Fix workflow schema: change const
, adding missing object
; etc.
#876
Conversation
Signed-off-by: Matthias Pichler <m.pichler@warrify.com>
Signed-off-by: Matthias Pichler <m.pichler@warrify.com>
Signed-off-by: Matthias Pichler <m.pichler@warrify.com>
Signed-off-by: Matthias Pichler <m.pichler@warrify.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Many thanks! ❤️
@matthias-pichler-warrify please do! 🙏 Can you also please add a GHA to validate if the YAML is formatted corrected? Also, I think we have a So please, don't forget to add a section in CONTRIBUTIONS.md about how to lint. <3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please add examples that validate these changes? 🙏
const
, adding missing object
; etc.
will do it separately though |
Signed-off-by: Matthias Pichler <m.pichler@warrify.com>
Signed-off-by: Matthias Pichler <m.pichler@warrify.com>
I added examples to validate the last two points ... the first two are a matter of the schema itself so a different validation would have to be added. |
Signed-off-by: Matthias Pichler <m.pichler@warrify.com>
working on this here: #883 |
Signed-off-by: Matthias Pichler m.pichler@warrify.com
Please specify parts of this PR update:
Discussion or Issue link:
What this PR does:
I adressed some issues with the workflow schema:
const
instead ofconstant
as described here: https://json-schema.org/understanding-json-schema/reference/consttype: object
directives that made the schema fail certain strict schema checks (specifically ajv complained about the use ofproperties
withouttype: object
)use
by allowing string values forauthentication
fields of tasksref
with the correct$ref
Additional information:
the schema is very inconsistently formatted: would it be okay for me to configure
yamllint
and format the schema (in a separate PR?)