Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix usage of endpoint in-call http tasks #877

Conversation

matthias-pichler
Copy link
Collaborator

Signed-off-by: Matthias Pichler m.pichler@warrify.com

Please specify parts of this PR update:

  • Specification
  • Schema
  • Examples
  • Extensions
  • Use Cases
  • Community
  • CTK
  • Other

Discussion or Issue link:

What this PR does:

The DSL describes the callHttp endpoint property as:

An URI or an object that describes the HTTP endpoint to call.

However:

  1. many examples used a uri field directly in call http tasks
  2. the schema did not allow to specify a string directly

so I fixed both

Additional information:

Signed-off-by: Matthias Pichler <m.pichler@warrify.com>
Signed-off-by: Matthias Pichler <m.pichler@warrify.com>
@matthias-pichler matthias-pichler force-pushed the fix-usage-of-endpoint-in-call-http branch from 3249ba3 to a07afc0 Compare June 3, 2024 13:33
Copy link
Member

@cdavernas cdavernas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Cheers!

Copy link
Member

@ricardozanini ricardozanini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry to be a PITA, but can you add an example? I think ours only has this structure:

endpoint:
    uri: ...

Signed-off-by: Matthias Pichler <m.pichler@warrify.com>
@matthias-pichler
Copy link
Collaborator Author

Sorry to be a PITA, but can you add an example? I think ours only has this structure:

endpoint:
    uri: ...

Sorry to be a PITA, but can you add an example? I think ours only has this structure:

endpoint:
    uri: ...

no worries ... added an example 👍

Copy link
Member

@ricardozanini ricardozanini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think in this case the format is uri-template since we want to support dynamic calls within the task.

schema/workflow.yaml Outdated Show resolved Hide resolved
examples/call-http-shorthand-endpoint.yaml Outdated Show resolved Hide resolved
Signed-off-by: Matthias Pichler <m.pichler@warrify.com>
@ricardozanini ricardozanini merged commit a25f33c into serverlessworkflow:main Jun 3, 2024
3 checks passed
@matthias-pichler matthias-pichler deleted the fix-usage-of-endpoint-in-call-http branch June 3, 2024 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants