Allow runtime-expressions for formatted strings #938
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthias-pichler
requested review from
ricardozanini and
cdavernas
as code owners
Signed-off-by: Matthias Pichler <m.pichler@warrify.com>
Signed-off-by: Matthias Pichler <m.pichler@warrify.com>
Signed-off-by: Matthias Pichler <m.pichler@warrify.com>
matthias-pichler
force-pushed
the
runtime-expressions
branch
from
d3d7bac
to
ec487e2
Compare
ricardozanini
approved these changes
Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Matthias Pichler m.pichler@warrify.com
Please specify parts of this PR update:
Discussion or Issue link:
Closes #937
What this PR does:
I allowed most strings that define a
formatproperty to also be a runtime expression. For that I added a schema for runtime expressions that validates that the start with${and end with}.I did not allow them for
auhtorityin oauth authentication anduriin external resources.Additional information:
the runtime expression regex allows leading and trailing whitespace, should we keep this ore restrict it?