Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding missing titles for better pojo generation #944

Merged

Conversation

fjtirado
Copy link
Collaborator

@fjtirado fjtirado commented Aug 2, 2024

Please specify parts of this PR update:

  • Specification
  • Schema
  • Examples
  • Extensions
  • Use Cases
  • Community
  • CTK
  • Other

Discussion or Issue link:

What this PR does:

Additional information:

Signed-off-by: Francisco Javier Tirado Sarti <ftirados@redhat.com>
Copy link
Member

@cdavernas cdavernas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, aside from a couple if minor comments! Thanks for your work man! ❤️

schema/workflow.yaml Outdated Show resolved Hide resolved
schema/workflow.yaml Outdated Show resolved Hide resolved
schema/workflow.yaml Outdated Show resolved Hide resolved
Signed-off-by: Francisco Javier Tirado Sarti <ftirados@redhat.com>
@fjtirado fjtirado requested a review from cdavernas August 2, 2024 12:31
Copy link
Member

@cdavernas cdavernas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@ricardozanini ricardozanini merged commit 333c83c into serverlessworkflow:main Aug 2, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants