Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify task and workflow arguments #953

Merged

Conversation

matthias-pichler
Copy link
Collaborator

Signed-off-by: Matthias Pichler m.pichler@warrify.com

Please specify parts of this PR update:

  • Specification
  • Schema
  • Examples
  • Extensions
  • Use Cases
  • Community
  • CTK
  • Other

Discussion or Issue link:

Closes #951

What this PR does:

It clarifies the contents of the $workflow and $task arguments

Additional information:

Signed-off-by: Matthias Pichler <m.pichler@warrify.com>
@cdavernas cdavernas added change: fix Something isn't working. Impacts in a minor version change. change: documentation Improvements or additions to documentation. It won't impact a version change. area: spec Changes in the Specification labels Aug 4, 2024
@cdavernas cdavernas added this to the v1.0.0-alpha3 milestone Aug 4, 2024
Copy link
Member

@cdavernas cdavernas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are on fire man! LGTM! Thanks ❤️

@matthias-pichler
Copy link
Collaborator Author

matthias-pichler commented Aug 5, 2024

@cdavernas @ricardozanini @fjtirado @JBBianchi should $task.input and $workflow.input contain the raw input before input.from is applied? This would justify their existence but would make then somewhat inconsistent with other uses of the word "input" (which usually refers to the filtered input).

should we use $task.rawInput and $workflow.rawInput instead?

@JBBianchi
Copy link
Member

should $task.input and $workflow.input contain the raw input before input.from is applied?

That's my understanding indeed.

should we use $task.rawInput and $workflow.rawInput instead?

I'm not against, it can bring some more clarity.

@fjtirado
Copy link
Collaborator

fjtirado commented Aug 5, 2024

@matthias-pichler-warrify Hmmm, I understand workflow.input and task.input in an intuitive way, so Im not in favour of adding raw prefix to them
I like the PR as it is ;)

@ricardozanini ricardozanini merged commit 7fcc3ca into serverlessworkflow:main Aug 6, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: spec Changes in the Specification change: documentation Improvements or additions to documentation. It won't impact a version change. change: fix Something isn't working. Impacts in a minor version change.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Document content of $workflow and $task arguments
5 participants