Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate uri scheme from error types #957

Merged

Conversation

matthias-pichler
Copy link
Collaborator

Signed-off-by: Matthias Pichler m.pichler@warrify.com

Please specify parts of this PR update:

  • Specification
  • Schema
  • Examples
  • Extensions
  • Use Cases
  • Community
  • CTK
  • Other

Discussion or Issue link:

Closes #954

What this PR does:

Error types unintendedly used https://https://

Additional information:

Signed-off-by: Matthias Pichler <m.pichler@warrify.com>
Copy link
Member

@cdavernas cdavernas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Many thanks ❤️

@cdavernas cdavernas added change: fix Something isn't working. Impacts in a minor version change. area: spec Changes in the Specification change: documentation Improvements or additions to documentation. It won't impact a version change. labels Aug 4, 2024
@cdavernas cdavernas added this to the v1.0.0-alpha3 milestone Aug 4, 2024
@ricardozanini ricardozanini merged commit ca94f62 into serverlessworkflow:main Aug 6, 2024
2 checks passed
@matthias-pichler matthias-pichler deleted the fix-error-types branch August 6, 2024 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: spec Changes in the Specification change: documentation Improvements or additions to documentation. It won't impact a version change. change: fix Something isn't working. Impacts in a minor version change.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Standard error types with duplicate https scheme
3 participants