Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a new arguments property to the script process #960

Merged
merged 4 commits into from
Aug 7, 2024
Merged

Add a new arguments property to the script process #960

merged 4 commits into from
Aug 7, 2024

Conversation

cdavernas
Copy link
Member

Please specify parts of this PR update:

  • Specification
  • Schema
  • Examples
  • Extensions
  • Use Cases
  • Community
  • CTK
  • Other

Discussion or Issue link:
#959

What this PR does:
Adds a new arguments property to the script process

@cdavernas
Updates both the DSL reference and schema to include script arguments
fd0d67f 
Signed-off-by: Charles d'Avernas <charles.davernas@neuroglia.io>
@cdavernas cdavernas added change: documentation Improvements or additions to documentation. It won't impact a version change. change: feature New feature or request. Impacts in a minor version change area: spec Changes in the Specification labels Aug 7, 2024
@cdavernas cdavernas added this to the v1.0.0-alpha3 milestone Aug 7, 2024
@cdavernas
Minor fix to the arguments property description
0f4e886 
Signed-off-by: Charles d'Avernas <charles.davernas@neuroglia.io>
ricardozanini
ricardozanini reviewed Aug 7, 2024
View reviewed changes
Copy link
Member

@ricardozanini ricardozanini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Can you please add an example to validate the schema change?

@cdavernas
Copy link
Member Author

@ricardozanini Will do!

@cdavernas
Added a new example for running script with arguments
0702aef 
Signed-off-by: Charles d'Avernas <charles.davernas@neuroglia.io>
@cdavernas cdavernas merged commit fbd77b0 into serverlessworkflow:main Aug 7, 2024
3 checks passed
@cdavernas cdavernas deleted the feat-script-arguments branch August 7, 2024 16:48
@cdavernas cdavernas mentioned this pull request Aug 8, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ricardozanini ricardozanini ricardozanini approved these changes

@fjtirado fjtirado fjtirado approved these changes

Assignees
No one assigned
Labels
area: spec Changes in the Specification change: documentation Improvements or additions to documentation. It won't impact a version change. change: feature New feature or request. Impacts in a minor version change
Projects
Progress Tracker
Status: Done
Milestone
v1.0.0-alpha3
Development

Successfully merging this pull request may close these issues.
3 participants
@cdavernas @ricardozanini @fjtirado