Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed inconsistencies between listen and emit #963

Conversation

JBBianchi
Copy link
Member

Redo of #926 and #943 because I messed up the history again -_-

Please specify parts of this PR update:

  • Specification
  • Schema
  • Examples
  • Extensions
  • Use Cases
  • Community
  • CTK
  • Other

Discussion or Issue link:
Closes #917 (and other little minor typo)

What this PR does:

  • Fixes inconsistencies between listen and emit
    • Added new event section in the specification documentation
    • Fixed the sample of emit in the specification documentation
    • Added new event definition in the JSON schema and referenced it in emit.event.with and eventFilter.with
  • Fixes a typo in the set feature
  • Fixed type of an http call endpoint by adding string
  • Added new (missing) endpoint section in the specification documentation
  • Escaped * character
  • Fixed double https://https://
  • Fixed links to runtime expressions
  • Fixed typo in implictly

Additional information:
-

Signed-off-by: Jean-Baptiste Bianchi <jb.bianchi@neuroglia.io>
Copy link
Member

@cdavernas cdavernas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks man!

Let's hope that this time it's the charm! 🤣 🤞

@ricardozanini ricardozanini merged commit 4e03cdb into serverlessworkflow:main Aug 7, 2024
3 checks passed
@JBBianchi JBBianchi deleted the fix-917-semantic-inconsistencies-listen-vs-emit branch August 9, 2024 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Semantic inconsistencies between listen and emit tasks
3 participants