Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate endpoint and externalResource definitions #975

Merged

Conversation

JBBianchi
Copy link
Member

@JBBianchi JBBianchi commented Aug 15, 2024

Please specify parts of this PR update:

  • Specification
  • Schema
  • Examples
  • Extensions
  • Use Cases
  • Community
  • CTK
  • Other

Discussion or Issue link:
#930

What this PR does:

This PR consolidates the definitions of endpoint and externalResource.

Endpoint

  • Updated endpoint to support two options (moved from CallHTTP.with.endpoint): a string URI template or an object with properties uri and authentication.
  • Ensured that uri is always required when using an object.

External resource

  • Added a new level endpoint which refers to the endpoint definition.

Signed-off-by: Jean-Baptiste Bianchi <jb.bianchi@neuroglia.io>
Signed-off-by: Jean-Baptiste Bianchi <jb.bianchi@neuroglia.io>
Copy link
Member

@cdavernas cdavernas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Cheers bro ❤️

@cdavernas cdavernas merged commit 16a331a into serverlessworkflow:main Aug 15, 2024
3 checks passed
@cdavernas cdavernas deleted the fix-930-endpoint-factoring branch August 15, 2024 12:55
cdavernas added a commit to serverlessworkflow/sdk-net that referenced this pull request Aug 21, 2024
…ntroduced by serverlessworkflow/specification#975

Signed-off-by: Charles d'Avernas <charles.davernas@neuroglia.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants