-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document the difference between an event-driven schedule and a startup listen task #987
Document the difference between an event-driven schedule and a startup listen task #987
Conversation
…artup listen task - Added examples to document event-driven and cron schedules Signed-off-by: Charles d'Avernas <charles.davernas@neuroglia.io>
…rkflow input Signed-off-by: Charles d'Avernas <charles.davernas@neuroglia.io>
…uroglia-io/serverless-workflow-specification into fix-schedule-on-documentation
one: | ||
with: | ||
type: com.example.hospital.events.patients.heartbeat.low | ||
do: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't we have to use a listener task instead in this example?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Depends on what you want to achieve.
The objective here is to trigger a new workflow when and only when the event is received.
Using a listen task would mean you'd have started a workflow out of the blue, then wait potentially forever for an event to be consumed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Based on our private conversation, we agreed to follow up with an issue to review the schedule.on
naming since it may confuse users. Some may expect that schedule
enforces a timestamp definition.
Co-authored-by: Ricardo Zanini <1538000+ricardozanini@users.noreply.github.com>
Co-authored-by: Ricardo Zanini <1538000+ricardozanini@users.noreply.github.com>
Co-authored-by: Ricardo Zanini <1538000+ricardozanini@users.noreply.github.com>
Co-authored-by: Ricardo Zanini <1538000+ricardozanini@users.noreply.github.com>
Co-authored-by: Ricardo Zanini <1538000+ricardozanini@users.noreply.github.com>
one: | ||
with: | ||
type: com.example.hospital.events.patients.heartbeat.low | ||
do: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Based on our private conversation, we agreed to follow up with an issue to review the schedule.on
naming since it may confuse users. Some may expect that schedule
enforces a timestamp definition.
Please specify parts of this PR update:
Discussion or Issue link:
Fixes #972
Fixes #977
What this PR does: