Fixed the ResourceEditor component's store to properly serialize resources upon initialization #407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y serialize resources upon initialization, thus resolving casing issues with V1Pod Signed-off-by: Charles d'Avernas <charles.davernas@neuroglia.io>
cdavernas
added
app: dashboard
|
To test, update an operator by setting the #sample operator configuration
apiVersion: synapse.io/v1
kind: Operator
metadata:
name: operator-1
namespace: default
creationTimestamp: 2024-09-12T09:35:25.2104316+02:00
generation: 3
resourceVersion: EB00AE1
spec:
runner:
api:
uri: http://localhost:5257
runtime:
native:
directory: ..\..\..\..\..\runner\Synapse.Runner\bin\Debug\net8.0\
executable: Synapse.Runner.exe
kubernetes:
podTemplate:
metadata: {}
spec:
containers:
- image: someimagexx
name: test
secrets:
volumeName: secrets
mountPath: /run/secrets/synapse
containerPlatform: docker
publishLifecycleEvents: true
status:
phase: running
|
JBBianchi
approved these changes
Sep 12, 2024
Comment on lines
+123
to
+124
| if (monacoEditorHelper.PreferredLanguage == PreferredLanguage.YAML) this.SetEditorValue(yamlSerializer.ConvertFromJson(jsonSerializer.SerializeToText(resource))); | ||
| else this.SetEditorValue(jsonSerializer.SerializeToText(resource)); |
There was a problem hiding this comment.
Optional but the following might be "prettier"
var editorValue = jsonSerializer.SerializeToText(resource);
if (monacoEditorHelper.PreferredLanguage == PreferredLanguage.YAML) editorValue = yamlSerializer.ConvertFromJson(editorValue);
this.SetEditorValue(editorValue):
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many thanks for submitting your Pull Request ❤️!
What this PR does / why we need it: