Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added DSL validation when creating a workflow in the Dashboard #413

Merged
merged 2 commits into from
Sep 13, 2024

Conversation

JBBianchi
Copy link
Member

Many thanks for submitting your Pull Request ❤️!

What this PR does / why we need it:
Adds DSL level validation when creating a workflow definition in the dashboard UI.

Special notes for reviewers:
/

Additional information (if needed):
Closes #410

Closes #410

Signed-off-by: Jean-Baptiste Bianchi <jb.bianchi@neuroglia.io>
@JBBianchi JBBianchi added type: enhancement New feature or request app: dashboard Concerns the Dashboard UI priority: medium Indicates an average priority issue weight: 1 An issue that has a very low development impact labels Sep 13, 2024
@JBBianchi JBBianchi added this to the v1.0.0 milestone Sep 13, 2024
@JBBianchi JBBianchi self-assigned this Sep 13, 2024
Signed-off-by: Jean-Baptiste Bianchi <jb.bianchi@neuroglia.io>
Copy link
Member

@cdavernas cdavernas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Cheers ❤️

@cdavernas cdavernas merged commit 9e7ec56 into main Sep 13, 2024
4 checks passed
@cdavernas cdavernas deleted the feat-dashboard-sdk-validation branch September 13, 2024 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app: dashboard Concerns the Dashboard UI priority: medium Indicates an average priority issue type: enhancement New feature or request weight: 1 An issue that has a very low development impact
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Validate workflow using the SDK
2 participants