Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the WorkflowExecutionContext to properly set the status of an ended task #433

Merged
merged 1 commit into from
Oct 21, 2024

Conversation

cdavernas
Copy link
Member

Many thanks for submitting your Pull Request ❤️!

What this PR does / why we need it:

  • Fixes the WorkflowExecutionContext to properly set the status of an ended task, which was being wrongly set to the workflow instance's status

… status of an ended task

Signed-off-by: Charles d'Avernas <charles.davernas@neuroglia.io>
@cdavernas cdavernas added priority: high Indicates a high priority issue weight: 1 An issue that has a very low development impact app: runner Concerns the Runner type: fix labels Oct 21, 2024
@cdavernas cdavernas added this to the v1.0.0 milestone Oct 21, 2024
@cdavernas cdavernas self-assigned this Oct 21, 2024
@cdavernas
Copy link
Member Author

@JBBianchi FYI

@cdavernas cdavernas merged commit c173756 into main Oct 21, 2024
4 checks passed
@cdavernas cdavernas deleted the fix-task-cloud-event-status branch October 21, 2024 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app: runner Concerns the Runner priority: high Indicates a high priority issue type: fix weight: 1 An issue that has a very low development impact
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant