Fixed namespace provisioning #512
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…serialize `Namespaces` to `NamespaceDefinitions` Fixes #509 Signed-off-by: Charles d'Avernas <charles.davernas@neuroglia.io>
…sioner` Signed-off-by: Charles d'Avernas <charles.davernas@neuroglia.io>
There was a problem hiding this comment.
Pull Request Overview
This PR fixes namespace provisioning by updating the database initialization service to properly handle namespace resources. The changes rename the database initializer service for clarity and correct the deserialization type for namespace resources.
- Renamed
WorkflowDatabaseInitializertoDatabaseProvisionerto better reflect its broader responsibilities - Fixed namespace deserialization from
NamespaceDefinitiontoNamespacetype
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| Program.cs | Updates service registration to use the renamed DatabaseProvisioner |
| DatabaseProvisioner.cs | Renames class and fixes namespace deserialization type |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many thanks for submitting your Pull Request ❤️!
What this PR does / why we need it: