feat: add an interface for window/logMessage #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the same API design as the Node library, with methods on connection.console
Isakdl
approved these changes
Nov 26, 2024
Contributor
Isakdl
left a comment
Isakdl
left a comment
There was a problem hiding this comment.
Love it! Thank you for the PR!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello 👋 Thanks for putting this package together, it's made getting started much, much easier.
I'm coming from the Node world, having used vscode-languageserver-node quite a bit. I noticed there were a couple of niceties from that library that I was missing from
lsp_server, this logger being one of them. Figured I would share this with you in case you'd like to include it out of the box.This use the same API design as the Node library, with methods on connection.console.