-
-
Notifications
You must be signed in to change notification settings - Fork 426
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Small Documentation Error #255
Comments
Hi Rachel, If you want to submit a pull request that would be awesome. The documentation site reads from our Github. You can find it under If not, I will leave this up for @danpastori's review since he is way better at JavaScript than me 😀 |
Oh boy! The only reason I signed up for github was to send you those emails about AmplitudeJS. I want to help, but just read the github documentation on pull requests. At this point, I don’t understand much of it. I will study it and try to do it. I think it will take me a while. I want to help. Amplitude is a nice open source project. I’m not using it for songs, but it works for my use case.
Wish I were better at this stuff. Thanks again for your help.
…-Rachel
On Apr 13, 2018, at 5:51 AM, Jay Rogers ***@***.***> wrote:
Hi Rachel,
If you want to submit a pull request that would be awesome. The documentation site reads from our Github. You can find it under /docs.
If not, I will leave this up for @danpastori <https://github.com/danpastori>'s review since he is way better at JavaScript than me 😀
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub <#255 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AkhlbpouUqrcjBeZwtUa_phk0tU56JH0ks5toJ8-gaJpZM4TSv-S>.
|
No worries, thanks for the compliments! |
Hi @ValiantCuriosity, the documentation has been updated in the dev branch: https://github.com/521dimensions/amplitudejs/tree/dev Thanks for finding this one! |
Hi Jay,
I'm trying so hard to get the "setTimeOut() method to work at the end of the JSON file. It just isn't working. I'm trying to use it with callback: song_change.
"callbacks": { 'song_change': function(){ setTimeout... } }
At any rate, while I've been fighting with this problem, I noticed what I think is an error in the documentation that is found here:
https://521dimensions.com/open-source/amplitudejs/docs#pause
It currently reads:
I think it should read "Amplitude.pause()"
I hope this helps. I'll be looking forward to the "Complete How To Build a Player" that you mentioned.
Have a great day.
Best Regards,
-Rachel
The text was updated successfully, but these errors were encountered: