Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small Documentation Error #255

Closed
ValiantCuriosity opened this issue Apr 13, 2018 · 4 comments
Closed

Small Documentation Error #255

ValiantCuriosity opened this issue Apr 13, 2018 · 4 comments
Assignees

Comments

@ValiantCuriosity
Copy link

amplitudedocumentationerror
Hi Jay,

I'm trying so hard to get the "setTimeOut() method to work at the end of the JSON file. It just isn't working. I'm trying to use it with callback: song_change.
"callbacks": { 'song_change': function(){ setTimeout... } }
At any rate, while I've been fighting with this problem, I noticed what I think is an error in the documentation that is found here:
https://521dimensions.com/open-source/amplitudejs/docs#pause

It currently reads:

Pause
This simply pauses whatever song is active.
Amplitude.play()

I think it should read "Amplitude.pause()"

I hope this helps. I'll be looking forward to the "Complete How To Build a Player" that you mentioned.

Have a great day.
Best Regards,
-Rachel

@jaydrogers
Copy link
Member

Hi Rachel,

If you want to submit a pull request that would be awesome. The documentation site reads from our Github. You can find it under /docs.

If not, I will leave this up for @danpastori's review since he is way better at JavaScript than me 😀

@ValiantCuriosity
Copy link
Author

ValiantCuriosity commented Apr 13, 2018 via email

@jaydrogers
Copy link
Member

No worries, thanks for the compliments!

@danpastori
Copy link
Contributor

Hi @ValiantCuriosity, the documentation has been updated in the dev branch: https://github.com/521dimensions/amplitudejs/tree/dev Thanks for finding this one!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants