Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clicking next too quickly causes player control lockup #419

Closed
cclark-00 opened this issue Apr 25, 2020 · 1 comment
Closed

Clicking next too quickly causes player control lockup #419

cclark-00 opened this issue Apr 25, 2020 · 1 comment
Assignees
Labels
Bug: Needs Confirmation 🧐 Bugs that are reported, but needs to be confirmed and replicated.

Comments

@cclark-00
Copy link

Issue description

Clicking 'next song' button too rapidly causes JS error getFloat in bufferedProgressElements.js parseFloat call due to config.buffered being NaN.

Environment

Windows 10 home

  • What's My Browser Support link: Firefox 75
  • Amplitude.js Version: 5.0.3

Steps to reproduce the issue

  1. Click next song rapidly. Not reliably reproducible. Could be due to a large (90+) playlist, or using Amplitude.init callbacks; it only started showing up after those two additions to my JS code.

What is expected?

Link to where issue can be reproduced

Additional details / screenshots

Sample fix is in my fork. I tested config.buffered for NaN before running getFloat in 3 places.

@cclark-00 cclark-00 added the Bug: Needs Confirmation 🧐 Bugs that are reported, but needs to be confirmed and replicated. label Apr 25, 2020
@danpastori
Copy link
Contributor

I added the changes from your fork. Thanks for pointing that out! It's a good check to have in there before trying to compute a failing number.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug: Needs Confirmation 🧐 Bugs that are reported, but needs to be confirmed and replicated.
Projects
None yet
Development

No branches or pull requests

2 participants