-
-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Laravel Autorun: Fixing folder permission on the fly #172
Conversation
I like where this is going and I appreciate that you used the S6 Overlay methods to do this too. I've had this happen to me a few times before too. Are you able to give me steps to replicate the error you have above? I'd like to do some testing on my end too. Also, do you think it we should have the directories controlled by an environment variable but default it? I wonder if we need to check if the directories exist too (to prevent warnings or errors) |
I got this error on a clean installation of Laravel via composer on Ubuntu WSL2 |
Are you able to share the steps to replicate? |
Thanks, this probably all stems from this command:
When you run that, it defaults it as The PR proposed is one solution, but there are also deeper levels to solve this. I'm also afraid the container will still run into an issue even after executing because it will:
As you can see, the fix is running at step #2, where it needs to run after step #4. S6 Overlay provided things like this in their v2, but you can see they have made changes: https://github.com/just-containers/s6-overlay#fixing-ownership-and-permissions This permissions issue is something I've been aware of for sometime, but I just haven't thought of the best solution yet. |
Simple solutionSet env variables Just type Then set these values in environment section of your
ExplanationYou've linked project directory to |
Even with setting these variables, a Docker run command will default to Test it out yourself with:
You can see the
|
Just adding a note it was on my list to investigate this today 😃 Tracking it here: #179 |
Can we have this? I'm facing this issue.