Allow referencing a non-PodSpec-able application in Custom Projection #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Custom Projection section did not clarify that the .spec.application can also reference a non-PodSpec-able resources. Updated core spec to mention that through Custom Projection, the .spec.application MAY reference a non-PodSpec-able resource. Also, Updated the Custom Projection section to highlight that an implementation of the spec might opt in to allow referencing non-PodSpec-able applications.
scothis
reviewed
Sep 14, 2020
baijum
suggested changes
Sep 15, 2020
Co-authored-by: Scott Andrews <scott@andrews.me>
nebhale
approved these changes
Sep 15, 2020
arthurdm
approved these changes
Sep 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds some clarification around referencing a non-
PodSpec-able resources in the.spec.applicationthrough Custom Projection. It updates both the core spec as well as the Custom Projection section.