Remove integer based indexing to limit containers #171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Baiju Muthukadan <baiju.m.mail@gmail.com> Closes servicebinding#166
Signed-off-by: Baiju Muthukadan <baiju.m.mail@gmail.com>
scothis
approved these changes
Jun 25, 2021
nebhale
approved these changes
Jul 8, 2021
arthurdm
approved these changes
Jul 8, 2021
scothis
added a commit
to scothis/service-bindings
that referenced
this pull request
Jul 20, 2021
Since the container index is not defined as semantically meaningful, it is inherently unstable to make security related decisions based on. Use the container name instead to restrict access to specific containers. This capability was removed from the spec. Refs: servicebinding/spec#171 Signed-off-by: Scott Andrews <andrewssc@vmware.com>
scothis
added a commit
to vmware-tanzu/servicebinding
that referenced
this pull request
Jul 20, 2021
Since the container index is not defined as semantically meaningful, it is inherently unstable to make security related decisions based on. Use the container name instead to restrict access to specific containers. This capability was removed from the spec. Refs: servicebinding/spec#171 Signed-off-by: Scott Andrews <andrewssc@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Baiju Muthukadan baiju.m.mail@gmail.com
Closes #166