Skip to content

Make .GetAttributes() extension internal #374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 17, 2025
Merged

Make .GetAttributes() extension internal #374

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6088eac
Make `.GetAttributes()` internal
SergeiPavlov Apr 16, 2025
8b4a957
.GetAttribute()
SergeiPavlov Apr 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions Orm/Xtensive.Orm/Reflection/AttributeHelper.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ private static void AddAttributesFromBase(ref TAttribute[] attributes, MemberInf
}
}

public static TAttribute[] Get(MemberInfo member, AttributeSearchOptions options) =>
internal static TAttribute[] Get(MemberInfo member, AttributeSearchOptions options) =>
Dictionary.GetOrAdd(new PerAttributeKey(member.MetadataToken, member.Module.ModuleHandle, options), ExtractAttributesByKey, member);
}

Expand All @@ -79,7 +79,7 @@ public static TAttribute[] Get(MemberInfo member, AttributeSearchOptions options
/// <param name="member">Member to get attributes of.</param>
/// <param name="options">Attribute search options.</param>
/// <returns>An array of attributes of specified type.</returns>
public static IReadOnlyList<TAttribute> GetAttributes<TAttribute>(this MemberInfo member, AttributeSearchOptions options = AttributeSearchOptions.InheritNone)
internal static IReadOnlyList<TAttribute> GetAttributes<TAttribute>(this MemberInfo member, AttributeSearchOptions options = AttributeSearchOptions.InheritNone)
where TAttribute : Attribute => AttributeDictionary<TAttribute>.Get(member, options);

/// <summary>
Expand All @@ -94,7 +94,7 @@ public static IReadOnlyList<TAttribute> GetAttributes<TAttribute>(this MemberInf
/// throws <see cref="InvalidOperationException"/>, if there is more then one attribute of specified type found.
/// </returns>
/// <exception cref="InvalidOperationException">Thrown if there is more then one attribute of specified type found.</exception>
public static TAttribute GetAttribute<TAttribute>(this MemberInfo member, AttributeSearchOptions options = AttributeSearchOptions.InheritNone)
internal static TAttribute GetAttribute<TAttribute>(this MemberInfo member, AttributeSearchOptions options = AttributeSearchOptions.InheritNone)
where TAttribute : Attribute
{
var attributes = AttributeDictionary<TAttribute>.Get(member, options);
Expand Down