Added missing macOS 10.6+ IOSurface functions #459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xanathar
commented
Aug 11, 2021
| @@ -143,7 +149,7 @@ impl IOSurface { | |||
| let error_msg = error_msg.to_string_lossy(); | |||
| // This will only actually leak memory if error_msg is a `Cow::Owned`, which | |||
| // will only happen if the platform gives us invalid unicode. | |||
| panic!(error_msg.leak()); | |||
| panic!("{}", error_msg.leak()); | |||
There was a problem hiding this comment.
This is not relevant to the PR itself, but fixes a warning at compile time.
|
@bors-servo r+ |
|
📌 Commit c127f49 has been approved by |
bors-servo
added a commit
that referenced
this pull request
Aug 12, 2021
Added missing macOS 10.6+ IOSurface functions This adds a few `sys` entry points for IOSurface functions. I also made those public, so that code outside the IOSurface module can call and use them. I didn't add "rusty" wrappers as most of these functions are likely to be used in unsafe contexts anyway. I limited this to all functions supported in macOS 10.6.
|
💥 Test timed out |
|
@bors-servo r+ |
|
💡 This pull request was already approved, no need to approve it again.
|
|
📌 Commit c127f49 has been approved by |
|
☀️ Test successful - checks-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a few
sysentry points for IOSurface functions.I also made those public, so that code outside the IOSurface module can call and use them. I didn't add "rusty" wrappers as most of these functions are likely to be used in unsafe contexts anyway.
I limited this to all functions supported in macOS 10.6.