-
Notifications
You must be signed in to change notification settings - Fork 222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NSColor: add AppKit-defined colors #660
base: main
Are you sure you want to change the base?
Conversation
Looks like Is there any preprocessor/directive already in use to detect what version of macOS is being built against? Or should I just remove them? |
Add AppKit-defined UI Element Colors and Standard Colors. See https://developer.apple.com/documentation/appkit/nscolor#1651631
4160e3f
to
c0d59c6
Compare
Part of the issue here is that you're running tests that need the new symbols, but if you didn't do that, then things would compile, leaving up to the person using the crate to sort it out. I'm not sure what's better. |
An option is to add a |
There is some precedent for using cargo features:
I was thinking along the lines of how it's done in |
Add AppKit-defined UI Element Colors and Standard Colors.
See https://developer.apple.com/documentation/appkit/nscolor#1651631