You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Jul 10, 2023. It is now read-only.
I've noticed several problems when worked with the code:
Some inconsistencies in coding style: the order of use statements varies between files (it would be better to use the same style / order everywhere; one of the possible styles).
When multiple functions/structures/types are imported from the module, both use something::{str1, test, example} and use something::{ str1, test, example } styles are used, it would be nice to stick to one of the versions.
Sometimes the text width is more than 100 characters.
There is a lot of boilerplate code in each module when it comes to TCFType trait implementation. I think it makes sense to use impl_TCFType! macro from core-foundation-sys or something similar.
The text was updated successfully, but these errors were encountered:
I've noticed several problems when worked with the code:
use
statements varies between files (it would be better to use the same style / order everywhere; one of the possible styles).use something::{str1, test, example}
anduse something::{ str1, test, example }
styles are used, it would be nice to stick to one of the versions.TCFType
trait implementation. I think it makes sense to useimpl_TCFType!
macro fromcore-foundation-sys
or something similar.The text was updated successfully, but these errors were encountered: