This repository has been archived by the owner on Jul 10, 2023. It is now read-only.
Accommodate change of empty vector representation in nightly libstd. #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The empty sentinel value used to be 0x1; now it is the minimum alignment of the contained type. To support both nightly and stable versions of rustc, we check for any pointer that is equal or less than the minimum alignment of the type that heap_size_of receives. If the given pointer is larger, we pass it on to the jemalloc heap-measuring API.
|
@bors-servo r+ |
|
📌 Commit cd5f46e has been approved by |
bors-servo
pushed a commit
that referenced
this pull request
May 18, 2017
Accommodate change of empty vector representation in nightly libstd. <!-- Reviewable:start --> This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/heapsize/81) <!-- Reviewable:end -->
|
☀️ Test successful - status-travis |
This was referenced May 20, 2017
|
What was the number of the change in libstd? |
|
Specifically the changes to |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is