Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find ways to avoid hitting the API limit #124

Open
jdm opened this issue May 13, 2016 · 8 comments
Open

Find ways to avoid hitting the API limit #124

jdm opened this issue May 13, 2016 · 8 comments

Comments

@jdm
Copy link
Member

jdm commented May 13, 2016

Possibly alternate between two accounts for each time the webhook is invoked?

@jdm
Copy link
Member Author

jdm commented May 13, 2016

It would be useful to log times when we hit the API limit, too.

@wafflespeanut
Copy link
Contributor

wafflespeanut commented May 18, 2016

Could this be behind #110 and #112, since we don't know what else is causing such "unpredictability"?

@jdm
Copy link
Member Author

jdm commented May 18, 2016

I don't see how it could be responsible for #112.

@wafflespeanut
Copy link
Contributor

wafflespeanut commented May 19, 2016

Okay, I (must've) misread it. It shouldn't cause #112

@wafflespeanut
Copy link
Contributor

Are we currently going for all events? Because, then, we could associate some set of events to an account - say pull_request for "highfive" and issue for "highfive-2"?

@jdm
Copy link
Member Author

jdm commented May 29, 2016

There's no account associated with receiving events. Highfive is in control of which account details are used with each API request it makes.

@wafflespeanut
Copy link
Contributor

This pops in often these days 😭

@jdm
Copy link
Member Author

jdm commented Jun 22, 2016

Note: rate limit responses look like a 403 Forbidden response code, with an x-ratelimit-remaining header with value 0, with a JSON response with a message field that states that the rate limit was exceeded.

Mark-Simulacrum pushed a commit to Mark-Simulacrum/highfive that referenced this issue Sep 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants