Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Buildbot log fetching doesn't work for --always-succeed jobs #207

Open
jdm opened this issue Jan 23, 2019 · 2 comments
Open

Buildbot log fetching doesn't work for --always-succeed jobs #207

jdm opened this issue Jan 23, 2019 · 2 comments

Comments

@jdm
Copy link
Member

jdm commented Jan 23, 2019

https://github.com/servo/highfive/blob/master/handlers/homu_status/__init__.py#L27-L37 looks for a buildbot job that fails, then finds the stdio log for the failed job and prints that. For jobs like the bluetooth tests that fail if a test fails, that works perfectly fine. For jobs like the rest of the WPT tests, where the actual test run job passes and a subsequent log filtering job fails (and doesn't print anything to stdio) this does not work.

@jdm
Copy link
Member Author

jdm commented Jan 23, 2019

A quick fix would be to look for any log with -errorsummary.log in the name as well; sadly, that output is less generally helpful than the actual WPT job stdio.

@jdm
Copy link
Member Author

jdm commented Jan 23, 2019

Basic support added in #207. It would be nice to get the original "succeeding" job's output instead.

Mark-Simulacrum pushed a commit to Mark-Simulacrum/highfive that referenced this issue Sep 8, 2020
Remove myself (dwijnand) from Cargo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant