-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider putting WPT test failures into a gist if there are too many #99
Comments
I'm ambivalent about this. The whole point of having highfive show the WPT test failures is to make our life easier (i.e., we don't have to navigate a couple of pages to get the test results) 😄 |
I think we should truncate the test log output instead, if there are more than 15 failures or so. |
A gist seems like a good compromise to me, since it's only a single link away versus the status quo of many possible links to choose from. |
Okay, then we can limit the posted log (to 20 lines or something), and link to the gist if it gets exceeded. In such cases, we could also go for showing only the test names and results in the PR, and putting other details into the gist. |
I'm not super interested in a doing a bunch of processing on the output - if 500 tests fail, it would still be a nuisance to scroll through just the test names. I'd say post the output inline if it's <30 lines, otherwise make a gist and post the link instead. |
fair enough, falling back to emilio's idea... |
Updating shebang to use first interpreter on the PATH
It shouldn't be hard to create a gist if the report is more than, let's say, 30 lines, and it would prevent overloading the thread too much.
Ideally the report could also contain how many tests passed, how many failed and how many timed out.
The text was updated successfully, but these errors were encountered: