Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider putting WPT test failures into a gist if there are too many #99

Open
emilio opened this issue Apr 24, 2016 · 6 comments
Open

Comments

@emilio
Copy link
Member

emilio commented Apr 24, 2016

It shouldn't be hard to create a gist if the report is more than, let's say, 30 lines, and it would prevent overloading the thread too much.

Ideally the report could also contain how many tests passed, how many failed and how many timed out.

@wafflespeanut
Copy link
Contributor

I'm ambivalent about this. The whole point of having highfive show the WPT test failures is to make our life easier (i.e., we don't have to navigate a couple of pages to get the test results) 😄

@KiChjang
Copy link
Contributor

I think we should truncate the test log output instead, if there are more than 15 failures or so.

@jdm
Copy link
Member

jdm commented Apr 25, 2016

A gist seems like a good compromise to me, since it's only a single link away versus the status quo of many possible links to choose from.

@wafflespeanut
Copy link
Contributor

Okay, then we can limit the posted log (to 20 lines or something), and link to the gist if it gets exceeded. In such cases, we could also go for showing only the test names and results in the PR, and putting other details into the gist.

@jdm
Copy link
Member

jdm commented Apr 25, 2016

I'm not super interested in a doing a bunch of processing on the output - if 500 tests fail, it would still be a nuisance to scroll through just the test names. I'd say post the output inline if it's <30 lines, otherwise make a gist and post the link instead.

@wafflespeanut
Copy link
Contributor

fair enough, falling back to emilio's idea...

Mark-Simulacrum pushed a commit to Mark-Simulacrum/highfive that referenced this issue Sep 8, 2020
Updating shebang to use first interpreter on the PATH
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants