You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Mar 20, 2024. It is now read-only.
Cargo just stopped using rustfmt in travis, it was just too annoying to keep up with. I was thinking of building a bot that submitted PR's when cargo +stable fmt had changes. But we already have a bot, can homu just run fmt and amend its merge commits?
The text was updated successfully, but these errors were encountered:
no human ever needs to run that command to get CI to pass.
Well the workflow I imagine is:
Alis is new to the project and rust tooling.
She clones the master branch of the project.
She makes some changes. She accidentally gets rls to format it. The master branch of the project uses fmt so only her changes get formatted.
Next in the revue some changes are requested.
She makes the changes over the course of several tentative commits. None of those CI runs are wasted on "CI is red because you did not run fmt." No one needs to explain what fmt is nore how to use it.
When the reviewer is satisfied homu merges the PR, to ensure the master branch of the project uses fmt homu runs cargo fmt on the merge before committing/testing/pushing.
Also I don't think highfive is set up to make commits.
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Cargo just stopped using rustfmt in travis, it was just too annoying to keep up with. I was thinking of building a bot that submitted PR's when
cargo +stable fmt
had changes. But we already have a bot, can homu just run fmt and amend its merge commits?The text was updated successfully, but these errors were encountered: