Skip to content

QualName should be re-exported #210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
tomaka opened this issue Jun 1, 2016 · 0 comments · Fixed by #268
Closed

QualName should be re-exported #210

tomaka opened this issue Jun 1, 2016 · 0 comments · Fixed by #268

Comments

@tomaka
Copy link

tomaka commented Jun 1, 2016

The QualName type is used as part of the API, but it is pulled from the string_cache crate.
QualName should be reexported with a pub use, just like Tendril already is.
This was referenced Apr 25, 2017
Closed
Merged
bors-servo pushed a commit that referenced this issue May 2, 2017
Auto merge of #268 - Ygg01:xhtml5ever, r=SimonSapin,Ygg01
cee43bd 
Xhtml5ever

Ok, this is a large one.

Fixes #266, fixes #261, fixes #210.

It moves html5ever into separate folder, renames html5ever macros markup5ever and stores common code there.

Here is short summary of what I know is and isn't done.

- [x] Make every crate in the repo use a single workspace
- [x] Make sure Travis-CI is running every test
- [x] Rename the the html5ever_atoms crate to markup5ever and update html5ever and xml5ever to use it.
- [x] Increment version numbers
- [x] Make it so that users of either html5ever or xml5ever don’t need to have an explicit dependency to markup5ever
- [x] Export QualName #210
- [x] let markup5ever generate entities.json #261
- [ ] **Move TokenSink to markup5ever**
- [x] Move TreeSink to markup5ever
- [x] Move BufferQueue to markup5ever
- [x] Move SmallCharSet to markup5ever
- [ ] **Deal with driver.rs**

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/html5ever/268)
<!-- Reviewable:end -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Xhtml5ever Ygg01/html5ever
1 participant
@tomaka