Skip to content

Use std::time instead of deprecated crate time #213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 21, 2016
Merged

Use std::time instead of deprecated crate time #213

merged 2 commits into from
Aug 21, 2016

Conversation

spk
Copy link
Contributor

@spk spk commented Aug 20, 2016 •
edited by larsbergstrom
Loading

Crate time is deprecated; switch to std::time
Cheers

This change is Reviewable

@jdm
Copy link
Member

jdm commented Aug 20, 2016

This change reduces the accuracy of the timer from nanoseconds to seconds, which is much less useful. Can we improve on that?

@SimonSapin
Copy link
Member

I’m making a PR to Rust’s standard library to add a Duration method doing this, but in the meantime please use d.as_secs() * 1_000_000_000 + u64::from(d.subsec_nanos())

@SimonSapin
Copy link
Member

rust-lang/rust#35868

@SimonSapin
Copy link
Member

@bors-servo r+

@bors-servo
Copy link
Contributor

📌 Commit c377068 has been approved by SimonSapin

@bors-servo
Copy link
Contributor

⌛ Testing commit c377068 with merge d4cd4d4...

bors-servo pushed a commit that referenced this pull request Aug 21, 2016
Auto merge of #213 - spk:remove-crate-time, r=SimonSapin
d4cd4d4 
Use std::time instead of deprecated crate time

Crate time is deprecated; switch to `std::time`
Cheers

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/html5ever/213)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

☀️ Test successful - status-travis

@bors-servo bors-servo merged commit c377068 into servo:master Aug 21, 2016
@spk spk deleted the remove-crate-time branch September 5, 2016 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@spk @jdm @SimonSapin @bors-servo